Skip to content

fix(ci): prevent parallel git diff when detecting new issues in monorepo#1092

Merged
matejchalk merged 2 commits intomainfrom
fix-ci-issues-shallow-lock
Aug 28, 2025
Merged

fix(ci): prevent parallel git diff when detecting new issues in monorepo#1092
matejchalk merged 2 commits intomainfrom
fix-ci-issues-shallow-lock

Conversation

@matejchalk
Copy link
Collaborator

@matejchalk matejchalk commented Aug 28, 2025 •
edited
Loading

3 different monorepos have encountered the same bug, recently. It happens towards the end of the run, after bulk compare has completed succesfully.

 NX   Successfully ran target code-pushup for 8 projects




file:///home/runner/work/_actions/code-pushup/github-action/v0/node_modules/simple-git/dist/esm/index.js:4462
        return { error: new GitError(void 0, error.toString("utf-8")) };
^
Error: fatal: Unable to create '/home/runner/work/radar-kit-fu/radar-kit-fu/.git/shallow.lock': File exists.

Another git process seems to be running in this repository, e.g.
an editor opened by 'git commit'. Please make sure all processes
are terminated then try again. If it still fails, a git process
may have crashed in this repository earlier:
remove the file manually to continue.

    at Object.action (file:///home/runner/work/_actions/code-pushup/github-action/v0/node_modules/simple-git/dist/esm/index.js:4462:1)
    at PluginStore.exec (file:///home/runner/work/_actions/code-pushup/github-action/v0/node_modules/simple-git/dist/esm/index.js:4501:1)
    at file:///home/runner/work/_actions/code-pushup/github-action/v0/node_modules/simple-git/dist/esm/index.js:1369:1
    at new Promise (<anonymous>)
    at GitExecutorChain.handleTaskData (file:///home/runner/work/_actions/code-pushup/github-action/v0/node_modules/simple-git/dist/esm/index.js:1367:1)
    at GitExecutorChain.<anonymous> (file:///home/runner/work/_actions/code-pushup/github-action/v0/node_modules/simple-git/dist/esm/index.js:1351:1)
    at Generator.next (<anonymous>)
    at fulfilled (file:///home/runner/work/_actions/code-pushup/github-action/v0/node_modules/simple-git/dist/esm/index.js:45:1)

After inspecting the source code, I believe the cause was findNewIssues being run in parallel, because it performs Git operations - git fetch origin main --depth=1 followed by git diff FETCH_HEAD HEAD ... - which fit the error message.

Refactored to ensure these operations are run sequentially.

@matejchalk matejchalk self-assigned this Aug 28, 2025
@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🧩 ci labels Aug 28, 2025
@nx-cloud
Copy link

nx-cloud bot commented Aug 28, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 5176de7

Command Status Duration Result
nx code-pushup -- compare --verbose ✅ Succeeded 7s View ↗
nx code-pushup -- --verbose ✅ Succeeded 6m 16s View ↗
nx code-pushup -- print-config --verbose --outp... ✅ Succeeded 6s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-28 07:27:19 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 28, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1092

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1092

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1092

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1092

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1092

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1092

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1092

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1092

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1092

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1092

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1092

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1092

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1092

commit: 5176de7

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit c4a8b09 with previous commit 5b4069a.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 32 🔴 31 ↓ −1.1
Code coverage 🟢 91 🟢 91 ↓ −0.1
Security 🟡 64 🟡 64 –
Updates 🟡 85 🟡 85 –
Accessibility 🟢 92 🟢 92 –
Best Practices 🟢 100 🟢 100 –
SEO 🟡 61 🟡 61 –
Type Safety 🟢 100 🟢 100 –
Bug prevention 🟢 100 🟢 100 –
Miscellaneous 🟢 100 🟢 100 –
Code style 🟢 100 🟢 100 –
Documentation 🔴 23 🔴 23 –
👎 2 groups regressed, 👍 2 audits improved, 👎 4 audits regressed, 14 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 32 🔴 31 ↓ −1.1
Code coverage Code coverage metrics 🟢 91 🟢 91 ↓ −0.1

19 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟥 Root document took 680 ms 🟩 Root document took 530 ms ↓ −22.9 %
Lighthouse First Contentful Paint 🟥 3.1 s 🟥 3.2 s ↑ +3.1 %
Lighthouse Total Blocking Time 🟥 3,240 ms 🟥 7,640 ms ↑ +135.6 %
Lighthouse Speed Index 🟥 7.9 s 🟥 8.2 s ↑ +4 %
Code coverage Branch coverage 🟨 86.4 % 🟨 86.3 % ↓ −0.1 %
Code coverage Line coverage 🟨 87.6 % 🟨 87.6 % ↑ +0.1 %
Lighthouse Minimizes main-thread work 🟥 12.3 s 🟥 21.3 s ↑ +72.6 %
Lighthouse JavaScript execution time 🟥 5.0 s 🟥 10.8 s ↑ +116.3 %
Lighthouse Avoids enormous network payloads 🟨 Total size was 2,674 KiB 🟨 Total size was 2,676 KiB ↑ +0.1 %
Lighthouse Largest Contentful Paint 🟥 12.1 s 🟥 13.2 s ↑ +9.1 %
Lighthouse Time to Interactive 🟥 18.2 s 🟥 19.1 s ↑ +4.9 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +4.9 %
Lighthouse Max Potential First Input Delay 🟥 1,850 ms 🟥 2,480 ms ↑ +34.1 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 582 KiB 🟥 Potential savings of 560 KiB ↓ −34.1 %
Lighthouse Server Backend Latencies 🟩 1,590 ms 🟩 1,290 ms ↓ −18.6 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↑ +0.1 %
Lighthouse Network Round Trip Times 🟩 40 ms 🟩 60 ms ↑ +48.3 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 113 KiB 🟥 Potential savings of 113 KiB ↓ −2.2 %
JS Packages Outdated NPM dev dependencies. 🟨 49 outdated package versions (21 major, 23 minor, 5 patch) 🟨 50 outdated package versions (21 major, 23 minor, 6 patch) ↑ +2 %
Lighthouse Cumulative Layout Shift 🟩 0.001 🟩 0 ↓ −100 %

590 other audits are unchanged.

BioPhoton
BioPhoton approved these changes Aug 28, 2025
View reviewed changes
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@matejchalk matejchalk added the 🐛 bug something isn't working label Aug 28, 2025
@matejchalk matejchalk merged commit f5f9114 into main Aug 28, 2025
18 checks passed
@matejchalk matejchalk deleted the fix-ci-issues-shallow-lock branch August 28, 2025 07:28
@matejchalk matejchalk mentioned this pull request Aug 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BioPhoton BioPhoton BioPhoton approved these changes

Assignees

@matejchalk matejchalk

Labels

🐛 bug something isn't working 🧩 ci 📖 Project documentation improvements or additions to the project documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matejchalk @BioPhoton